Ok, after consulting with Henry and a clean build, it works for me in Safari. But in Firefox, my 2-button mouse does not work, only control-click. And in IE, I see no built-in menu.
I guess this is an improvement over the status quo, so approved, but I think you need to put back the test for button-2, at least in Firefox. On 2010-10-21, at 10:53, Henry Minsky wrote: > approved! > > On Thu, Oct 21, 2010 at 10:20 AM, Max Carlson <[email protected]> wrote: > >> Change maxcarlson-20101021-FXR by [email protected] on 2010-10-21 >> 08:15:07 MDT >> in /Users/maxcarlson/openlaszlo/trunk2 >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Fix DHTML context menus >> >> Bugs Fixed: LPP-9442 - regression in DHTML context menu >> >> Technical Reviewer: ptw >> QA Reviewer: hminsky >> >> Details: test/contextmenu/api.lzx - Update to eliminate warnings, add test >> for showBuiltInItems(). >> >> LzMouseKernel - Now that only global oncontextmenu is used, simplify global >> mouse handler to only have to deal with that kind of event. Pass >> contextmenu object directly to __showContextMenu(). >> >> Tests: test/contextmenu/api.lzx?lzr=dhtml to runs correctly. >> >> Files: >> M test/contextmenu/api.lzx >> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20101021-FXR.tar >> > > > > -- > Henry Minsky > Software Architect > [email protected]
