You're mostly right, as you will see from my subsequent change...

where I just moved the doc-comment out of the library, and now everything 
works.  Yes, I am too lazy to wait for my personal machine to do the doc build, 
so I tested with the build machine, which is not the nicest thing to do.  Now I 
have drunk all the coffee I can take for the day, and this solution builds on 
my personal machine, so I am trying once more on the build machine.  Fingers 
crossed.  :)

What's with the doc-comment?  It seems to make the doc generator only take the 
next XML tag and ignore everything else?

On 2010-10-30, at 13:03, André Bargull wrote:

> Not approved!
> 
> I'd do the following steps:
> - delete dataselectioninclude.lzx
> - rebuild lzx-autoincludes.properties, don't add any hand-crafted entries
> - open dataselectionmanager.lzx
> -- remove the comment about "we cannot directly include ..."
> -- add <include href="selectionmanager.lzx"/> at the top (!), directly after 
> the <library> start-tag
> -- remove any blank lines between the <!--- --> doc-comment and <class>
> [-- add "@lzxname dataselectionmanager" between @subtopic and @devnote] 
> (maybe this step is not necessary...)
> - rebuild the reference on your local machine
> - go and drink some coffee
> - come back to the computer
> - go and drink more coffee
> - come back again and see everything went fine
> 
> I think the issue was only caused by the <include> after the <!--- --> 
> doc-comment.
> 
> (Hmm, hopefully it's going to work for you, too. Otherwise this will turn out 
> to be a bit embarrassing for me, maybe I shouldn't have yelled so loud "Not 
> approved!" :-) )
> 
> 
> On 10/30/2010 1:21 PM, P T Withington wrote:
>> Change ptw-20101030-exq by [email protected] on 2010-10-30 06:59:08 EDT
>>     in /Users/ptw/OpenLaszlo/trunk-3
>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>> 
>> Summary: Get nightly builds working again
>> 
>> Bugs Fixed:  LPP-9475 4.7-based tree fails to compile in 4.9 with no useful 
>> error message
>> 
>> Technical Reviewer: [email protected] (pending)
>> QA Reviewer: antun (pending)
>> 
>> Details:
>>     Revert to work-around introduced in LPP-9180
>> 
>> Tests:
>>     kicking off a nightly build
>> 
>> Files:
>> M       WEB-INF/lps/misc/lzx-autoincludes.properties
>> M       lps/components/utils/dataselectioninclude.lzx
>> M       lps/components/utils/dataselectionmanager.lzx
>> 
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ptw-20101030-exq.tar
>> 
>> 


Reply via email to