I just checked this in as r17870, if you are still working...

On 2010-11-16, at 07:37, Captain Feng wrote:

> Have you checked in the fix to OL trunk?
> I can do the test in my local dev either.
> 
> thanks,
> -Fred
> 
> 2010/11/16 Captain Feng <[email protected]>
> 
>> Maybe you should use china branch to do the test:
>> https://github.com/mcarlson/components/tree/fredfeng-laszlochina
>> I checked in the parser code to china branch yesterday,  so I don't think
>> Max has time to review and merge it to trunk yet.
>> 
>> 
>> thanks,
>> -Fred
>> 
>> 2010/11/16 P T Withington <[email protected]>
>> 
>>> The .005 bug is just my new parser being overly-restrictive.  I will check
>>> in a fix.
>>> 
>>> But I have another question:
>>> 
>>> If I specify an rbg value in gradient-fill in the components demos, it
>>> does not work at all.  Have you improved the gradient-fill parser in a way
>>> that I do not know about?
>>> 
>>> On 2010-11-16, at 01:01, captain yu wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> This is Fred Feng.
>>>> I check out the latest OL and try to verify it:
>>>> It can recognize '0' now:
>>>>           gradient-fill: 'top,rgba(0,0,0,0) 0%,rgba(0,0,0,0) 100%';
>>>> But if i use the workaround way previous, will get the following error:
>>>> ERROR: Invalid CSS Color: 'rgba(0,0,0,.005)'
>>>> Is this error expected? or, can't we be compatible with both of them?
>>>> 
>>>> thanks,
>>>> -Fred
>>>> 
>>>> 2010/11/16 P T Withington <[email protected]>
>>>> 
>>>>> On 2010-11-15, at 18:33, André Bargull wrote:
>>>>> 
>>>>>>>  style: Bug discovered by new code -- the color type auto-quotes
>>>>>>>  its value property.  If you want the value to be an expression,
>>>>>>>  you must use ${}.
>>>>>> 
>>>>>> The "menuitembgcolor" uses the old `when="once|always|immediately"`
>>>>> syntax to declare a constraint, basically `<attribute
>>> name="menuitembgcolor"
>>>>> value="textfieldcolor" when="once" type="color"/>` should act the same
>>> as
>>>>> `<attribute name="menuitembgcolor" value="$once{textfieldcolor}"
>>>>> type="color"/>`.
>>>>> 
>>>>> Hm.  So it does...  need to investigate why that was not working then.
>>>>> 
>>>> 
>>>> 
>>>> 
>>>> --
>>>> captain
>>> 
>>> 
>> 
>> 
>> --
>> captain
>> 
> 
> 
> 
> -- 
> captain


Reply via email to