Approved! On 2010-11-30, at 12:33, Max Carlson wrote:
> Change maxcarlson-20101129-JGB by [email protected] on 2010-11-29 > 16:59:35 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED AGAIN: Explicitly handle transparent color values from the > compiler, correctly strip alpha from colors when rgba isn't supported > > Bugs Fixed: LPP-9547 - Got IE browser error "Invalid property value " at > LFCdhtml.js > > Technical Reviewer: ptw > QA Reviewer: yfang > > Details: Updated again to address Tucker's comments: > > ADded explicit test for null, improved warning. I'm going to check this in > now. > > Otherwise, updated to address Tucker's comments: > > Not approved. > > You should use LzColorUtils.colorfrominternal and alphafrominternal rather > than hard-coding the tests. > > Done! > > Otherwise, The summary sez it all... > > Tests: See LPP-9547 > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20101129-JGB.tar
