Issues:

1) '0' is not a valid CSS color, so why are we even worrying about this?

2) hextoint has a vague contract, shouldn't we just replace it with 
internalfromcss?

3) If none of the above, then we should just remove the global lookup from this 
API -- that only was there for dark-ages compatibility when the components 
defined colors in the global scope.  Surely we don't want to be doing that any 
more?

On 2010-12-13, at 17:52, Max Carlson wrote:

> Change maxcarlson-20101213-Yzi by maxcarl...@friendly on 2010-12-13 14:35:55 
> PST
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Fix LzColorUtils.hextoint('0') return value
> 
> Bugs Fixed: LPP-9586 - LzColorUtils.hextoint('0') returns a window object
> 
> Technical Reviewer: ptw
> QA Reviewer: hminsky
> 
> Details: Explicitly test values found in global to make sure they are numbers.
> 
> Tests: LzColorUtils.hextoint('0') returns a correct value in the debugger, 
> test/lfc/lzunit-lzutils.lzx?lzr=dhtml passes
> 
> Files:
> M       WEB-INF/lps/lfc/services/LzUtils.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20101213-Yzi.tar


Reply via email to