approved

On Thu, Dec 16, 2010 at 2:01 AM, Max Carlson <[email protected]> wrote:

> Agreed.  Otherwise, what do you think?
>
>
> On 12/15/10 10:16 PM, Henry Minsky wrote:
>
>> In the else clause of that 'if' statement, would it make sense to use
>> LzColorUtils.cssfrominternal()
>> to get an 'rgba' string that could have an alpha value, so that a non-IE
>> browser can make use of it?
>>
>>         var rgbcolor = LzColorUtils.torgb(shadowcolor, 'rgb');
>>         return inset + rgbcolor + " " + xoffset + " " + yoffset + " " +
>> this.CSSDimension(shadowblurradius);
>>
>>
>>
>>
>> On Thu, Dec 16, 2010 at 12:52 AM, Max Carlson <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>    Change maxcarlson-20101215-2CJ by maxcarl...@friendly on 2010-12-15
>>    21:19:38 PST
>>        in /Users/maxcarlson/openlaszlo/trunk-clean
>>        for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>>    Summary: Fix shadowcolor for RGBA values in IE
>>
>>    Bugs Fixed: LPP-9565 - Control the opacity for view shadow
>>
>>    Technical Reviewer: hminsky
>>    QA Reviewer: ptw
>>
>>    Details: IE only accepts RGB colors.  Simplify offset code.
>>
>>    Tests: demos/house.lzx?lzr=dhtml&lzt=html with:
>>
>>    highlight-color: rgba(22,137,200,.5);
>>
>>    runs normally in IE 8.
>>
>>    Files:
>>    M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>>
>>    Changeset:
>>
>> http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20101215-2CJ.tar
>>
>>
>>
>>
>> --
>> Henry Minsky
>> Software Architect
>> [email protected] <mailto:[email protected]>
>>
>>
>>


-- 
Henry Minsky
Software Architect
[email protected]

Reply via email to