Change maxcarlson-20110103-i8s by maxcarl...@friendly on 2011-01-03 12:52:57 PST
in /Users/maxcarlson/openlaszlo/trunk2/my-apps/components
for http://svn.lzxpatterns.com/components/trunk
Summary: Make classname for replicated lists dynamic
New Features: The 'listclass' attribute can be specified for <list/> and
<scrollablelist/>
Bugs Fixed: LPP-9592 - Make class for list dynamic
Technical Reviewer: hminsky
QA Reviewer: ffeng
Details: I'm going to check this in now. Updated to address Tucker's comments:
FWIW, instead of:
> > 'class': lz[this.itemclass]
you can say:
> > tag: this.itemclass
(makeChild supports both 'tag' and 'class'.)
Done!
Also, don't you want to validate that the itemclass is a subclass of listitem?
Gee, I guess you should write a type that does that...
I'll hold off on this a bit...
Henry's comments:
would be nice to see a test case with a list item class different from the
default
Done.
combobox_floater - Add itemclass attribute, constrain embedded scrollablelist's
itemclass to our itemclass.
library - Move list to list.lzx
listitem - Add includes, remove unused test
list - Move from library.lzx. Add setter for items to reset the replicator
nodes. Manually create the replicator based on the value of the itemclass
attribute.
scrollablelist - Add includes, itemclass attribute. Constrain embedded list's
itemclass to our itemclass.
house - Add test for custom listitem class.
Tests: demos/house.lzx runs like before, but the scrollablelist shows bird
icons as part of the listitems.
Files:
M lib/combobox/combobox_floater.lzx
M lib/list/library.lzx
M lib/list/listitem.lzx
A lib/list/list.lzx
M lib/list/scrollablelist.lzx
M demos/house.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20110103-i8s.tar
