before checking in...
LzContextMenu.lzs:
- please indent the lines
- please update LPP-6629
- "Sets the delegate which will be called when a menu item is selected.
An onselect event is also sent."
=> "Sets the delegate which will be called when the menu is opened. An
onmenuopen event is also sent." (This is for <contextmenu>, only
<contextmenuitem> sends an "onselect" event!)
LzDataNode.lzs:
- test\lfc\data\stringxml.lzx, test\lztest\lztest-lzdataelement.lzx,
test\lztest\lztest-lzdatanode.lzx, test\lztest\lztest-lzdatatext.lzx
still refer to "LzDataNode.stringToLzData(...)"
basecombobox.lzx:
- "this.interior.cbtext" may either be a <text> or an <inputtext>,
therefore you cannot replace "getText()" with "text" (does that mean we
need to un-deprecate <text>#getText()?)
LaszloView.lzs:
- description from setPlay() is now lost, b/c there isn't actually a
"play" attribute (just the "play" method)
- from setCursor() => "Or '' for default cursor." needs to be moved to
cursor declaration
- "setValign()" description sounds better to me than the current
"valign" description, other opinions here?
- no description for "align", needs to copied over from "setAlign()"
- set{Width, Height}() description also includes info about resource
stretching, copy to width/height?
- "layout" description does not include special case for removing
layout, that means {'class': 'none'}
-
On 1/5/2011 10:42 PM, Max Carlson wrote:
Change maxcarlson-20110105-EbF by maxcarl...@friendly on 2011-01-05 09:25:11 PST
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Remove @deprecated methods and properties from the LFC,
update docs
Bugs Fixed: LPP-9625 - Remove @deprecated methods and properties from the LFC,
LPP-7401 - setter-documentation
Technical Reviewer: hminsky
QA Reviewer: ptw,abargull
Details: Updated to address Andre's comments:
Not approved, because of LPP-7401. (I've just added a link from LPP-9625 to
LPP-7401 in JIRA. )
I went through with a fine-tooth comb and made sure all the documentation was
moved from the old setters.
lfc-undeclared - Remove contextmenuitem schema declaration, now that doc
comments are in place for LzContextMenuItem.
Otherwise:
WEB-INF/lps/* - Remove @deprecated methods and properties, except where marked
private (and used internally).
lps/components/*,demos/* - Remove use of deprecated APIs
Tests: All apps run like before, DHTML LFC is ~.5k smaller compressed.
Files:
M WEB-INF/lps/schema/lfc-undeclared.lzx
M WEB-INF/lps/lfc/services/LzUtils.lzs
M WEB-INF/lps/lfc/services/LzHistory.lzs
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/core/LzEventable.lzs
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/lfc/views/LzTLFInputText.lzs
M WEB-INF/lps/lfc/views/LzTLFText.lzs
M WEB-INF/lps/lfc/helpers/LzContextMenu.lzs
M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataText.lzs
M WEB-INF/lps/lfc/data/LzDataNode.lzs
M WEB-INF/lps/lfc/data/LzDataElement.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/lfc/data/LzParam.lzs
M lps/components/lz/windowpanel.lzx
M lps/components/base/basecombobox.lzx
M demos/lzpix/views/details.lzx
M demos/lzproject/lzx/lzproject/modules/BackendService.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20110105-EbF.tar
