Approved. Lucky for me the css presentation type is not used anywhere (yet).
You know we are dropping swf8 support in OL5? On 2011-01-08, at 12:02, André Bargull wrote: > Change bargull-20110108-2k4 by barg...@bargull02 on 2011-01-08 17:24:44 > in /home/anba/src/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: enhance reg-exp support for swf8 and move to lfc/compiler, fix > reg-exp in css presentation-type > > Bugs Fixed: LPP-9172 (SWF8: evaluating simple expressions no longer possible > in solo mode), LPP-9630 (No POSIX character classes in Javascript / replacer > function improperly used for String#replace) > > Technical Reviewer: ptw > QA Reviewer: (pending) > > Details: > - Moved swf8 regexp implementation from kernel to compiler/platform because > the RegExp constructor was called multiple times before the kernel include > (that doesn't quite work...) > > LzRegExp.lzs, regexp.js: > - Expanded String.replace to support function arguments and implemented the > "$" replacement patterns > > PresentationTypes.lzs: > - Replaced POSIX character class and fixed the replacer functions > > Tests: > lz.Type.PresentationTypes.css.present({leftPadding: 0}) yields "left-padding: > 0" > lz.Type.PresentationTypes.css.accept("left-padding: 0") yields {leftPadding: > '0'} > > "hello".replace("l", "$&$'$`$&$'$`$&") yields "hellohellohello" > > Files: > M lps/includes/source/regexp.js > D WEB-INF/lps/lfc/kernel/swf/LzRegExp.lzs > M WEB-INF/lps/lfc/kernel/swf/Library.lzs > D WEB-INF/lps/lfc/core/LzCache.lzs > M WEB-INF/lps/lfc/core/PresentationTypes.lzs > M WEB-INF/lps/lfc/core/Library.lzs > A + WEB-INF/lps/lfc/compiler/LzCache.lzs > A WEB-INF/lps/lfc/compiler/platform > A WEB-INF/lps/lfc/compiler/platform/swf > A + WEB-INF/lps/lfc/compiler/platform/swf/LzRegExp.lzs > M WEB-INF/lps/lfc/compiler/Library.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/bargull-20110108-2k4.tar >
