If the newly added files are new files, perhaps their author could say if they 
should be auto-included.  If they are very old, I would say they should not be 
included unless someone can make a case for it.

On 2011-01-09, at 16:06, André Bargull wrote:

> I'm not sure about the newly added files, but if you think they shouldn't be 
> included, I'll add them to exclusion list in "build-autoincludes.sh".
> 
> On 1/9/2011 9:08 PM, P T Withington wrote:
>> Note that this script is not perfect, so you should verify its output is 
>> sensible before committing any change to autoincludes.  For instance, do we 
>> mean to add the av and utils additions?
>> 
>> On 2011-01-09, at 12:28, André Bargull wrote:
>> 
>>> Change bargull-20110109-Uq5 by barg...@bargull02 on 2011-01-09 18:22:17
>>> in /home/anba/src/svn/openlaszlo/trunk
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>> 
>>> Summary: handle "mixin" for autoincludes script
>>> 
>>> Bugs Fixed: LPP-9635 (mixins not collected by autoinclude script)
>>> 
>>> Technical Reviewer: max
>>> QA Reviewer: (pending)
>>> 
>>> 
>>> Details:
>>> BuildAutoincludes.java:
>>> - collect "mixin" elements in addition to "class" and "interface"
>>> - change backslash to forward slash to be able to create autoincludes on 
>>> windows platforms
>>> 
>>> lzx-autoincludes.properties:
>>> - newly generated file from 'ant autoincludes'
>>> 
>>> 
>>> Tests:
>>> run 'ant autoincludes' and verify mixins are now automatically added
>>> 
>>> Files:
>>> M WEB-INF/lps/server/src/org/openlaszlo/utils/BuildAutoincludes.java
>>> M WEB-INF/lps/misc/lzx-autoincludes.properties
>>> 
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/bargull-20110109-Uq5.tar
>>> 
>> 
>> 


Reply via email to