Approved. Can you add your new runtime to test/smoke/compiler.lzl#testConditionalCompilation? Perhaps add some tests for André's new compile-time expression analyzer, e.g., test that
if ($dhtml && $mobile) assert $runtime == 'mobile' if ($dhtml && (! $mobile)) assert $runtime == 'dhtml' On 2011-01-11, at 20:50, Henry Minsky wrote: > Change hqm-20110111-RzY by [email protected] on 2011-01-11 20:30:42 EST > in /Users/hqm/openlaszlo/trunk1 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: add 'mobile' runtime, which is flavor of dhtml. Add 'mobile' button > to dev console > > New Features: > > Bugs Fixed: LPP-9644 , LPP-9646 > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > > Details: > > Add 'mobile' runtime. Remove hardcoded list of runtimes in a couple of places > and replace with > calls to enumerate the Compiler.KNOWN_RUNTIME > > Tests: > > compile an app with lzr=mobile, verify that $mobile and $dhtml are set to > true in runtime > > + verify compile time constant was handled at compile time, using this code > > hello.lzx: > <canvas> > <script when="immediate"> > if ($mobile) { Debug.info('$mobile was true'); } > if ($dhtml) { Debug.info('$dhtml was true'); } > </script> > > <simplelayout/> > <text text="${'runtime = '+$runtime}"/> > <text text="${'$dhtml = '+$dhtml}"/> > <text text="${'$mobile = '+$mobile}"/> > </canvas> > > inspecting the .js file for this, if you compile with runtime=dhtml, only the > "Debug.info('$dhtml was true');" statement should > be in the code. > > If you compile with $mobile, both "Debug.info('$mobile was true');" and > "Debug.info('$dhtml was true');" will be present. > > > > Files: > M WEB-INF/lps/lfc/buildlfc > M WEB-INF/lps/lfc/buildlfcbacktrace > M WEB-INF/lps/lfc/buildlfcdebug > M WEB-INF/lps/lfc/build.xml > M WEB-INF/lps/lfc/LaszloLibrary.lzs > M WEB-INF/lps/lfc/buildlfcprofile > M WEB-INF/lps/lfc/buildlfcprofiledebug > M WEB-INF/lps/server/src/org/openlaszlo/sc/lzsc.java > M > WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationEnvironment.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java > M WEB-INF/lps/templates/html-response_jp.xslt > M WEB-INF/lps/templates/html-response.xslt > M WEB-INF/lps/templates/embed-body_jp.xslt > M WEB-INF/lps/templates/embed-body.xslt > M WEB-INF/lps/templates/app-console_jp.xslt > M WEB-INF/lps/templates/app-console.xslt > M build.properties > M lps/admin/dev-console.lzx.swf > M lps/admin/dev-console.lzx > M lps/admin/lps/includes/lfc/LFCdhtml.js > M lps/admin/dev-console.lzx.js > M laszlo-explorer/build.xml > M laszlo-explorer/explore-nav.lzx > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20110111-RzY.tar
