Agree. I will add that to my change. On 2011-01-12, at 15:00, André Bargull wrote:
> <datapointer> defines a deleteNode() method, the method is rewritten to > destroy() b/c there is a deleteNode entry in > "WEB-INF/lps/misc/lzx-deprecated-methods.properties". I'd propose to remove > the entry in "lzx-deprecated-methods.properties"... > > > On 1/12/2011 8:50 PM, P T Withington wrote: >> I'll have to check into that. I'm guessing there is an LFC API that needs to >> be marked private. >> >> On Jan 12, 2011, at 14:33, Henry Minsky <[email protected] >> <mailto:[email protected]>> wrote: >> >>> >>> >>> Say, I'm getting this warning when I run smokecheck with this change, do I >>> need to regenerate the >>> schema manually somehow? >>> >>> /Users/hqm/openlaszlo/trunk-diamond/WEB-INF/lps/schema/lfc.lzx:258:32: >>> deleteNode is deprecated. This method will be compiled as<method >>> name='destroy' instead. Please update your sources. >>> >>> >>> /Users/hqm/openlaszlo/trunk-diamond/WEB-INF/lps/schema/lfc.lzx:260:29: an >>> attribute or method named 'destroy' already is defined on element interface >>> >>> >>> >>> On Wed, Jan 12, 2011 at 1:31 PM, P T Withington <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> [This is blocking the build, if you could review at high prio.] >>> >>> Change ptw-20110111-et5 by [email protected] <mailto:[email protected]> >>> on 2011-01-11 18:13:29 EST >>> in /Users/ptw/OpenLaszlo/trunk-3 >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Make `cdata` presentation type work >>> >>> Bugs Fixed: LPP-9649 Fencepost error in `cdata` presentation type >>> >>> Technical Reviewer: [email protected] >>> <mailto:[email protected]> (pending) >>> QA Reviewer: [email protected] >>> <mailto:[email protected]> (pending) >>> Doc Reviewer: [email protected] <mailto:[email protected]> (pending) >>> >>> Release Notes: >>> >>> <text> has a new attribute `cdata` that is of type `cdata` (as >>> opposed to `text` or `html`). This attribute is an alias for >>> `text`, but when using a data binding, style binding or using >>> acceptAttribute/presentAttribute, it will be properly xml >>> escaped/unescaped. In other words, if you want to bind the text >>> content to a string and _not_ have it interpreted as markup, you >>> would use this attribute. See the documentation for <text> for >>> example usage. >>> >>> Details: >>> >>> PresentationTypes: Make the presentation type `cdata` work. Make >>> `text` and `html` aliases. >>> >>> LzText: Add the `cdata:cdata` attribute per notes above. Clean >>> up doc, add example of using `cdata`. >>> >>> SchemaBuilder: Add support for documenting style bindings for >>> kernel classes. Recognize cdata as a builtin type. >>> >>> ViewSchema: Learn about the meta tags <containsElements> and >>> <forbiddenElements>. Make `text` and `html` types aliases and add >>> `cdata`. Permit `final` as an attribute property. >>> >>> NodeModel: Don't bitch about meta tags or names on builtin >>> classes. For now, emit builtin-type info on instances. >>> >>> Compiler: Don't try to compile meta tags. >>> >>> ClassModel: Permit meta tags. Model builtins (from schema), so >>> we can get accurate type descriptions. >>> >>> Tests: >>> >>> Files: >>> M WEB-INF/lps/lfc/core/PresentationTypes.lzs >>> M WEB-INF/lps/lfc/views/LzText.lzs >>> M >>> WEB-INF/lps/server/src/org/openlaszlo/js2doc/SchemaBuilder.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java >>> M >>> WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationError.java >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110111-et5.tar >>> >>> >>> >>> >>> -- >>> Henry Minsky >>> Software Architect >>> [email protected] <mailto:[email protected]> >>> >>>
