Every instance-allocated "var" declaration is in "__ivars__", so that includes "var onx", too.

Concerning your statement in JIRA:
But if I can generate a more correct schema without relying on the developer 
getting the documentation just right, I would rather do that.

The schema pretty relies on doc comments, especially the @lzxtype is really important - not only for identifying events.


On 1/14/2011 11:57 PM, P T Withington wrote:
Holy smokes, where do they come from?

I will re-open.

But I had to check in to get a build because of other dependencies.

[Of course, the way our event system currently works, you are allowed to listen 
for any event you like.  It does not have to 'exist'.  Not that this is a 
feature we want or need to preserve.  It's just the way things currently work.]

On 2011-01-14, at 17:06, André Bargull wrote:

Not approved.

Did you take a look at the newly generated schema file? There are now a bunch 
of<event>s declared which don't actually exist.

[...]
<event final="true" name="ononx"/>
<event final="true" name="onony"/>
[...]



On 1/14/2011 5:52 PM, P T Withington wrote:
Change ptw-20110114-g1J by [email protected] on 2011-01-14 11:50:09 EST
     in /Users/ptw/OpenLaszlo/trunk-3
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Ensure implicit attribute events are in schema

Bugs Fixed: LPP-9675 Certain attributes not in schema (text/ontext)

Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)

Details:


Tests:
     test case from bug, smokecheck

Files:
M       WEB-INF/lps/server/src/org/openlaszlo/js2doc/SchemaBuilder.java
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110114-g1J.tar



Reply via email to