Maybe you want to split this review among yourselves because it's rather lengthy. Note that I didn't actually differentiate between currently used classes and stale ones (that'd require too much time...). I've just enabled the corresponding errors in eclipse (e.g. for missing @Override annotations) and went through all files with errors. I'm going to work on the js2doc and sc package in a subsequent change.

Change bargull-20110207-sju by bargull@Bargull02 on 2011-02-07 16:51:25
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Update java sources for Java 5

New Features:

Bugs Fixed: LPP-9736 (Clean up java sources) (partial)

Technical Reviewer: hqm, max, ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Overview:


Details:
This one big (and boring) change:
- Java5 generics used everywhere where applicable
-- certain 3rd-party APIs don't provide good support for generics, notably jdom, in these cases I've used wildcards as a fallback (List<?> etc.)

- Replaced loops using java.util.Iterator with for-each loops

- @Override annotations for all overridden methods

- StringBuffer replaced with StringBuilder to avoid the synchronization overhead -- but only for local variables, I didn't touch any public methods or class variables etc.

- Explicit allocation of wrapper classes (Integer, Long, Boolean, etc) is almost never necessary
-- replaced with valueOf() methods resp. auto-boxing

- Updated deprecated method calls
-- javax.servlet.http.HttpUtils.getRequestURL() -> HttpServletRequest.getRequestURL() -- parameter configuration of Apache httpclient (see org.openlaszlo.data.HTTPDataSource)

- Removed dead code and organized imports

- org.openlaszlo.compiler.Compiler.processCompilerInstructions()
-- replaced this (creative?) use of ClassCastExceptions with a custom jdom-filter


Tests:
compile lps.jar

Files:
M WEB-INF/lps/server/src/org/openlaszlo/media/TTF2FFT.java
M WEB-INF/lps/server/src/org/openlaszlo/media/Main.java
M WEB-INF/lps/server/src/org/openlaszlo/media/Transcoder.java
M WEB-INF/lps/server/src/org/openlaszlo/media/GIF89a.java
M WEB-INF/lps/server/src/org/openlaszlo/media/ImageMontageMaker.java
M WEB-INF/lps/server/src/org/openlaszlo/test/netsize/UrlSizer.java
M WEB-INF/lps/server/src/org/openlaszlo/test/netsize/TotalSizer.java
M WEB-INF/lps/server/src/org/openlaszlo/test/netsize/Netsize.java
M WEB-INF/lps/server/src/org/openlaszlo/test/netsize/Sizer.java
M WEB-INF/lps/server/src/org/openlaszlo/test/netsize/AppSizer.java
M WEB-INF/lps/server/src/org/openlaszlo/test/utf8dec.java
M WEB-INF/lps/server/src/org/openlaszlo/test/unzip.java
M WEB-INF/lps/server/src/org/openlaszlo/test/bigpost.java
M WEB-INF/lps/server/src/org/openlaszlo/test/gzip.java
M WEB-INF/lps/server/src/org/openlaszlo/test/gunzip.java
M WEB-INF/lps/server/src/org/openlaszlo/test/debugserver.java
M WEB-INF/lps/server/src/org/openlaszlo/test/etag.java
M WEB-INF/lps/server/src/org/openlaszlo/test/ttfdump.java
M WEB-INF/lps/server/src/org/openlaszlo/test/dec2utf8.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/TypeMap.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/SystemProperties.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/ServerErrors.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/Ghost.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/Dataset.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/SystemProp.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/SignMeUp.java
M WEB-INF/lps/server/src/org/openlaszlo/test/xmlrpc/PerfTest.java
M WEB-INF/lps/server/src/org/openlaszlo/test/unicode.java
M WEB-INF/lps/server/src/org/openlaszlo/test/copyswf.java
M WEB-INF/lps/server/src/org/openlaszlo/css/StyleProperty.java
M WEB-INF/lps/server/src/org/openlaszlo/css/CSSHandler.java
M WEB-INF/lps/server/src/org/openlaszlo/css/Rule.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/LZWebAppRemote.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/LZHttpSessionRemote.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/LZDefaultSOAPEncodingTypeMapping.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/LZSOAPHandler.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/encoding/JSONObjectDeserializer.java M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/encoding/JSONSimpleDeserializer.java M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/encoding/JSONArrayDeserializer.java M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/encoding/SOAPDataEncoder.java M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/encoding/JSONSimpleDeserializerFactory.java M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/encoding/LZArraySerializer.java M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/LZDefaultTypeMapping.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/ComplexType.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/LZSOAPMessage.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/SchemaParser.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/ArrayWrapper.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/ClientSOAPService.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/WSDLParser.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/LZSOAPService.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/soap/LZSOAPUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/LZGsonMarshaller.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/LZJsonMarshaller.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/LZClientObject.java
M WEB-INF/lps/server/src/org/openlaszlo/remote/json/LZReturnObject.java
M WEB-INF/lps/server/src/org/openlaszlo/cm/CachedInfo.java
M WEB-INF/lps/server/src/org/openlaszlo/cm/Main.java
M WEB-INF/lps/server/src/org/openlaszlo/cm/TrackingFileResolver.java
M WEB-INF/lps/server/src/org/openlaszlo/cm/CompilationManager.java
M WEB-INF/lps/server/src/org/openlaszlo/cm/DependencyTracker.java
M WEB-INF/lps/server/src/org/openlaszlo/connection/HTTPConnection.java
M WEB-INF/lps/server/src/org/openlaszlo/connection/Application.java
M WEB-INF/lps/server/src/org/openlaszlo/connection/SwfByte.java
M WEB-INF/lps/server/src/org/openlaszlo/connection/ConnectionGroup.java
M WEB-INF/lps/server/src/org/openlaszlo/connection/ConnectionAgent.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/DataEncoder.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/Schema.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/XMLRPCCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/XMLUtils_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/XMLUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/DataCommon.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/DataCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/Main.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/XMLRPCJSONCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/DataContext.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/FileUtils_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/FileUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/TempFileInputStream.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/DeployMain.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/LZUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/HashIntTable.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/LZHttpUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/ComparisonMap.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/DeploySOLOSWF.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/LZDeleteMethod.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/ChainedException.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/SetUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/DeployUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/LZPutMethod.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/BuildAutoincludes.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/SWFUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/ContentEncoding.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/DeploySOLODHTML.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/VersionMap.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/ListFormat.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/LZGetMethod.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/StringUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/NaturalOrderComparator.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/LZPostMethod.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/TransformUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/utils/DateUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/auth/Authentication.java
M WEB-INF/lps/server/src/org/openlaszlo/auth/HTTPAuthentication.java
M WEB-INF/lps/server/src/org/openlaszlo/auth/RoleAuthentication.java
M WEB-INF/lps/server/src/org/openlaszlo/auth/NullAuthentication.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/Cache.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/CachedInfo.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/MediaCache.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/RequestCache.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/DataCache.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/PersistentMap.java
M WEB-INF/lps/server/src/org/openlaszlo/cache/XMLDataCache.java
M WEB-INF/lps/server/src/org/openlaszlo/server/Configuration.java
M WEB-INF/lps/server/src/org/openlaszlo/server/Option.java
M WEB-INF/lps/server/src/org/openlaszlo/server/LPS.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/ContentEncoding.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/Responder.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCACHEINFO.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderLOG.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderSERVERINFO.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderMESSAGE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCLEARLOG.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCompile.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderDISCONNECT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCONNECT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderAGENTLIST.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderXMLDATA.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderSWF.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderSOURCE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderAPP_CONSOLE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderAGENTMESSAGE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderLIB.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderOBJECT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderWINDOW.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderDATA.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderLIST.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderINFO_XML.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCONNECTIONINFO.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/TemplateResponder.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderJSCRIPT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderConnectionAgent.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderSOAPINFO.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderMEDIA.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderFILTER.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderEVAL.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderAdmin.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCONNECTIONLOGIN.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderGC.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCONNECTIONLOGOUT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderConnection.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderPROFILE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderXML.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderJAVARPCINFO.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderERRORCOUNT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCache.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderLFC.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderHTML.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderLOGCONFIG.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCLEARCACHE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderSETCACHESIZE.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCANVAS.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderSTAT.java M WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderUTCSWF.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/LZNullServlet.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/LZBindingListener.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/LZViewer.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/LoadCount.java
M WEB-INF/lps/server/src/org/openlaszlo/servlets/LZServlet.java
M WEB-INF/lps/server/src/org/openlaszlo/data/MediaConverter.java
M WEB-INF/lps/server/src/org/openlaszlo/data/Data.java
M WEB-INF/lps/server/src/org/openlaszlo/data/HttpData.java
M WEB-INF/lps/server/src/org/openlaszlo/data/SessionBindingMap.java
M WEB-INF/lps/server/src/org/openlaszlo/data/helpers/ILaszloRPCAdapter.java
M WEB-INF/lps/server/src/org/openlaszlo/data/helpers/LaszloRPCAdapter.java
M WEB-INF/lps/server/src/org/openlaszlo/data/helpers/mappings/CastBasicTypes.java M WEB-INF/lps/server/src/org/openlaszlo/data/helpers/mappings/CastTableToObject.java M WEB-INF/lps/server/src/org/openlaszlo/data/helpers/mappings/StructureMethodList.java
M WEB-INF/lps/server/src/org/openlaszlo/data/XMLGrabber.java
M WEB-INF/lps/server/src/org/openlaszlo/data/XMLConverter.java
M WEB-INF/lps/server/src/org/openlaszlo/data/json/SOAPDataSource.java
M WEB-INF/lps/server/src/org/openlaszlo/data/DataSource.java
M WEB-INF/lps/server/src/org/openlaszlo/data/FileDataSource.java
M WEB-INF/lps/server/src/org/openlaszlo/data/HTTPDataSource.java
M WEB-INF/lps/server/src/org/openlaszlo/data/JavaDataSource.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SecurityCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ObjectWriter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SolutionMessages.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NullWriter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/TypeCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/LineMetrics.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/MixinCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ResourceCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SourceLocator.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ElementCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationErrorHandler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/InterfaceCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFWriter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/FileResolver.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/FontCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/FontManager.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryWriter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/UnknownAttributeException.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationEnvironment.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryCompilation.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/DataCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ImportCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/IntermediateWriter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ScriptElementCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/WrapperHeaders.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/AttributeSpec.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/TextCompiler_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/TextCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/DebugCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/FontInfo.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/StyleSheetCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SplashCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationError.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ElementWithLocationInfo.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilerUtils.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SourceLocatorSAXOutputter.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/bargull-20110207-sju.tar

Reply via email to