I just started to write an email about the missing mayAddParens() calls, but you beat me!

The extra calls to mayAddParens() should only be necessary for visitForVarInStatement() and visitForEachVarStatement(), because only the ForVarInStatement() resp ForEachVarStatement() grammar productions have this crippled down variable declaration.

On 2/8/2011 5:26 PM, P T Withington wrote:
Change ptw-20110208-mlv by [email protected] on 2011-02-08 11:23:11 EST
     in /Users/ptw/OpenLaszlo/trunk-3
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Unparse expressions in for* initializers correctly

Bugs Fixed:  LPP-6975 "for each..in" statement

Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)

Details:
     Backtrace mode inserts comma-expressions to track stack.  Unparser
     must be prepared for them.

Tests:
     smokecheck in dhtml+backtrace x {firefox,safari,ie}

Files:
M       WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110208-mlv.tar

Reply via email to