[Max this is our top bug, if you can expedite review, it would be appreciated.  
Thanks!]

Change ptw-20110209-rBd by [email protected] on 2011-02-09 19:25:17 EST
    in /Users/ptw/OpenLaszlo/trunk-3
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Straighten out 'button 2' event a little

Bugs Fixed: LPP-9664 DHTML: Need copy/paste context menu items in text and edit 
text. (partial)

Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)

Overview:

    No context menu was showing up over text elements because of the
    way mouse events are handled -- they ended up going through the
    global handler, which simply stripped off the fact that they were
    button-2 events and sent them on as button-1 events.  The result
    was that as soon as the context menu was displayed, it was
    immediately hidden by the bogus button-1 event.

Details:

    Remove swf8_contextmenu kludge.  It is no longer desired (and
    probably didn't work anyways, since there is a separate tree of
    context divs).  Don't confuse button-2 events with events of the
    same name from button-1!  Why not pass on the target view of  a
    global mouse event if you have it?

Tests:

    Default context menus now show up over text elements in DHTML.
    Prior to this change, a text element would only show a context
    menu if it had its own context menu.

    You can verify this change by simply loading any app in
    dhtml+debug mode and noticing that the debugger context menu now
    appears when you click over the console output pane.  Prior to
    this change, you could only see the debugger context menu if you
    clicked on the title bar of the console.

Files:
M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M       WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110209-rBd.tar

Reply via email to