Indeed. I added it and checked in. I kicked off build to verify.
On 2011-02-17, at 17:38, Henry Minsky wrote: > Actually, hold on a sec, the test case in lztest is giving me this, I think > you forgot to add this file to the changeset.. > > > [exec] cp: test/lztest/lzodir2/lzo-lib.lzx.proto: No such file or > directory > [exec] Compiling: test/lztest/lzodir2/lzo-lib.lzx to lzo-lib.lzo > [exec] Compilation errors occurred: > [exec] test/lztest/lzodir2/lzo-lib.lzx: file not found: > /Users/hqm/openlaszlo/trunk-diamond/test/lztest/lzodir2/lzo-lib.lzx (No such > file or directory) > [exec] > [exec] Compiling: test/lztest/lzodir/lzo-lib-extref.lzx to > lzo-lib-extref.lzo > > On Thu, Feb 17, 2011 at 5:30 PM, Henry Minsky <[email protected]>wrote: > >> approved >> >> >> On Thu, Feb 17, 2011 at 3:42 PM, P T Withington <[email protected]> wrote: >> >>> Change ptw-20110217-14x by [email protected] on 2011-02-17 15:16:53 EST >>> in /Users/ptw/OpenLaszlo/trunk >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Warn (and gracefully degrade) when asked to include an 'inner' >>> LZO in another >>> >>> Bugs Fixed: LPP-9769 Missing interface in LZO compile >>> >>> Technical Reviewer: [email protected] (pending) >>> QA Reviewer: [email protected] (pending) >>> Doc Reviewer: [email protected] (pending) >>> >>> Release Notes: >>> >>> If you try to compile a library to a binary library and that >>> library has an inner library that is also compiled to a binary >>> library, the compiler will issue a warning, saying that it is >>> ignoring the inner binary library. Instead the compiler will >>> include the source of the inner library. >>> >>> If your intent is to separately compile the two libraries, you >>> need to move the inner library to a separate directory to indicate >>> that it is indeed to be separately compiled. >>> >>> Details: >>> >>> test/lztest*, build-tools/prepare-lzo-test: Correct lzo test to >>> not use the forbidden 'inner lzo' pattern. >>> >>> FileResolver: Warn if not linking and an 'inner lzo' is found. >>> Include the source of the inner lzo instead. >>> >>> Parser: Pass env to FileResolver. >>> >>> Tests: >>> >>> smokecheck, ant lztest, Jade compile: (cd client; ant >>> -Drelease.id=999 build-libraries; cd future/lzmail; lzc --debug >>> main.lzx) >>> >>> Files: >>> M test/lztest/lztest-lzo-main.lzx >>> M test/lztest/lztest-lzo-classref.lzx >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/FileResolver.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java >>> M build-tools/prepare-lzo-test.sh >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110217-14x.tar >>> >> >> >> >> -- >> Henry Minsky >> Software Architect >> [email protected] >> >> >> > > > -- > Henry Minsky > Software Architect > [email protected]
