Ok, I see that somehow got deleted. Not sure how or why, I will reinstate that
and re-submit for review.
On 2011-02-18, at 18:38, André Bargull wrote:
>> // Just check method declarations on regular node (if an override
>> // was detected!).
>> // Method declarations inside of class definitions will be already
>> // checked elsewhere,
>> // in the call from ClassCompiler.updateSchema to schema.addElement
>> *// But user classes are instances of the meta-class <class>, that means
>> // class-allocated methods are methods on those instances, so we need
>> // to check method declarations in this case, too.*
>> if (isdef ? ALLOCATION_CLASS.equals(allocation) : override) {
>> schema.checkInstanceMethodDeclaration(element, getUserTagName(),
>> name, env);
>> }
>
> I think this code was the relevant one (from
> NodeModel#addMethodInternal(...)). My note about meta-class and
> class-allocated methods applies to LPP-9662.
>
>
> On 2/19/2011 12:29 AM, André Bargull wrote:
>> Only approved for LPP-9747.
>>
>> LPP-9662: I still only see eight errors
>> "test/compiler_errors/final-method-override-reserved.lzx". I think you've
>> also removed some java code in r17548 which needs to be added back.
>>
>>
>> On 2/19/2011 12:06 AM, P T Withington wrote:
>>> Change ptw-20110218-cjp by [email protected] on 2011-02-18 18:00:28 EST
>>> in /Users/ptw/OpenLaszlo/trunk-devo
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Clean up lfc-undeclared.lzx
>>>
>>> Bugs Fixed:
>>> LPP-9662 Overriding Function#{apply, call} allowed in<class>
>>> LPP-9747 SWF10: Explicit<datapath> declarations in class
>>> definitions lead to compiler error
>>>
>>> Technical Reviewer: [email protected] (pending)
>>> QA Reviewer: [email protected] (pending)
>>>
>>> Details:
>>> Put back erroneously deleted apply and call declarations (with a
>>> comment to remind me not to do that again). Add missing
>>> psuedo-attribute declaration for $datapath (and a comment).
>>>
>>> Tests:
>>> test cases from bug reports
>>>
>>> Files:
>>> M WEB-INF/lps/schema/lfc-undeclared.lzx
>>>
>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110218-cjp.tar
>>>
