This fixes the NPE error in components/test/mega/main.lzx?lzr=swf10.
Approved!
On 3/16/11 4:06 PM, P T Withington wrote:
Change ptw-20110316-CLP by [email protected] on 2011-03-16 17:29:28 EDT
in /Users/ptw/OpenLaszlo/trunk-devo
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix broken CSS optimization
Bugs Fixed: LPP-9785 CSS Parser needs to break up parsing of large rule sets
Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)
Overview:
The [name='...'] selector optimization was just plain broken, so
by default many CSS rules were being applied that should not have.
Details:
LzCSSStyle: Don't fail if there is a CSS rule that refers to a
non-existent tag. Move complex attribute matches out to a
subroutine, inlining the simple case. If there is a attribute
match rule on name, use that to winnow rules, since name can never
be dynamic, it always has to apply, whether you are gathering
rules or evaluating rules.
debugger: Make the right-click menu a bit more useful by applying
it to the click target if applicable and only falling back to the
last nodeTarget when not.
Tests:
smokecheck, style/metasuite, and inspecting
newcomponents/test/mega/main.lzx as described in the bug reveals
that there are now only _four_ rules that apply to the search box.
Files:
M WEB-INF/lps/lfc/services/LzCSSStyle.lzs
M lps/components/debugger/debugger.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ptw-20110316-CLP.tar
