responseStatus needs to be set to 0 in LzHTTPLoader#open(), just like responseText and responseXML. Consider the case when a request is interrupted before responseStatus was set, without nulling responseStatus it'd return the value from the previous request.

nits :
- insert import for HTTPStatusEvent between Event and IOErrorEvent to keep alphabetical order - declaration of responseStatus should appear before responseText (or after responseXML) to keep responseText and responseXML together
- typing missing for responseStatus (should be "int")
- httpStatusHandler instead of onHTTPStatusHandler to comply with the rest of the handler names

Otherwise looks good to me!

On 4/13/2011 7:30 PM, Raju Bitter wrote:
Change raju-20110413-ppx by [email protected] on 2011-04-13 18:42:03 CEST
     in /Users/raju/src/svn/openlaszlo/trunk/WEB-INF/lps/lfc
     for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc

Summary: Support SWF10 HTTPStatusEvent for SOLO dataset requests

New Features:

Bugs Fixed: LPP-9894

Technical Reviewer: [email protected]
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Overview:
Since Flash Player 9 it's possible to retrieve the HTTP response status code 
for requests executed by a URLLoader object. The LFC 
(kernel/swf9/LzHTTPLoader.as) currently doesn't process that information, 
although it's available in Firefox, Safari, Chrome and Opera.

With this improvement the LzHTTPLoader would store the response code of the 
last HTTP request in the property responseStatus. Datasets don't expose the 
LzHTTPLoader#getResponseStatus method, but the method can be accessed through 
someDataset.dataRequest.loader.getResponseStatus().

Details:


Tests:
test/data/http-status-response-swf10-unproxied.lzx

Files:
A       test/data/http-status-response-swf10-unproxied.lzx
M       WEB-INF/lps/lfc/kernel/swf9/LzHTTPLoader.as

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/raju-20110413-ppx.tar


Reply via email to