Approved. Tested 3 cases: RTE using custom build in LPP-9935 RTE using local build of dojo RTE using default (google) build of dojo
Each loads a fully functional RTE. On Wed, May 18, 2011 at 9:42 AM, <[email protected]> wrote: > Change philip-20110518-Uxy by philip@PHILIP-I7 on 2011-05-18 09:22:37 EDT > in /cygdrive/c/clients/laszlo/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Support custom dojo builds in RTE component. > > New Features: > > Bugs Fixed: LPP-9935 > > Technical Reviewer: (pending) > QA Reviewer: amy > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > > Details: > If you specify "(local)" for the values of dojo_theme and dojo_js in the > rte component, no dojo code is automatically loaded. You must specify your > own wrapperfile, and that file should load a custom version of dojo. The > custom wrapper file can be identical to the default wrapper file with the > following changes: > > 1. Specify the css and js in the <head> section. In my example the custom > dojo is located at /trunk/dojo-laszlo-1.5.1: > > <link href="/trunk/dojo-laszlo-1.5.1/dijit/themes/tundra/tundra.css" > rel="stylesheet" type="text/css"> > <script src="/trunk/dojo-laszlo-1.5.1/dojo/dojo.js"></script> > <script src="/trunk/dojo-laszlo-1.5.1/dojo/laszlo_dojo.js"></script> > > dojo.js is the core part of dojo, and dojo-laszlo-1.5.1 is the custom-built > components. Note: when naming your custom dojo profile it has to be > something other than 'dojo' to avoid overwriting the dojo core file. In my > example, I named the profile dojo-laszlo. > > 2. Specify the theme class to use in the body tag: > > <body class="tundra" onload="lz.rte.manager.rte_loaded();"> > > > rte.lzx > - Change docs to describe use of (local) for dojo_theme and dojo_js. > > rtemanager.js > - Don't load dojo components when (local) is specified. > - Generate an event to the rte component when the wrapper file is loaded, > rather than waiting for dojo to load. > > rtewrapper.html > - Set gutters="false" in the layout to tighten up layout of the editor and > the optional buttons. (I've been running this change for a while). > > Tests: > Run test case I added to LPP-9935. This requires a custom dojo build using > the profile specified in jira. > > Files: > M lps/components/extensions/rte.lzx > M lps/includes/rtewrapper.html > M lps/includes/source/rtemanager.js > > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/philip-20110518-Uxy.tar >
