The problem is that there is a kludge in the $style applicator that
coerces any string that can be parsed as a number into a number
before it applies it. This is not right. If you want a number, you
should use a number. If you want a string, you should use a string.
Ideally, I would have removed the kludge altogether, but that would
end up breaking a lot of existing code. Can you suggest a better
wording? Perhaps:
WARNING: The use of strings for numeric values is deprecated.
Right now this is a runtime warning. To tell you the offending CSS,
I would have to do some work in the compiler. File a bug please if
you'd like that.
But you could also use your newfound regexp skills to just find and
fix all your css files at once:
find . -name '*.css' -print0 | xargs -0 grep '"[0-9a-fA-F]+"'
:)
On 2007-01-06, at 16:47 EST, Benjamin Shine wrote:
Numbers and colors shouldn't be quoted in css. Only strings should
be quoted. This was a bad idiom that I think I introduced early on,
and that Tucker just repaired with the fix for LPP-3356.
Instead of
fontsize: "10"; /* wrong */
do
fontsize: 10; /* correct */
It is giving you a poor suggestion because most of the uses of the
quoted-string idiom were for colors:
bgcolor : "0x000001"; /* bad, shouldn't be quoted */
bgcolor: #000001; /* correct */
However, string values should be quoted:
label : "Silliest Kitty Cat in the Whole World"; /* good */
not
label : Silliest Kitty Cat in the Whole World; /* bad, string
should be quoted */
On Jan 6, 2007, at 12:46 PM, Sarah Allen wrote:
WARNING: Invalid CSS value for «mtext#1| .titletext».fontsize:
`"10"`. Use: `#a00000`.
does this mean I shouldn't be using a string anymore? and it is
just giving me a poor suggestion?
It sure would be nice if it told me what css file had the problem...
Sarah
benjamin shine
software engineer
[EMAIL PROTECTED]
