Hi Roland,

On 13/07/2005, at 5:15 AM, Roland Stigge wrote:

Hi,

I'm attaching a mail that I got regarding a bug report I previously forwarded to this forum. It includes two possible solutions to the problem. To be consistent with the original latex2html, which one will be included in the latex2html codebase?

The file to examine in the source distribution is:  pstoimg.pin
which should be at version:  1.19 .
Would you please check that version number.

Since  pstoimg  is derived from  pstoimg.pin  the fix
should be made there.
Then when you run the installation:
  ./configure
  make
  make install

a corrected  pstoimg  should then result.

The source bundle to obtain is:

    http://www.latex2html.org/current/latex2html-2002-2-1.tar.gz

dated  25-Oct-2004 .



Thanks!

bye,
  Roland


Package: latex2html
Version: 2002-2-1-10
Followup-For: Bug #132451

with respect to the pstoimg Perl script breaking when the -depth 24 or
-color 24 options were used:

  (don't know where the other stuff in this bug report came from)

$reduce_color is only getting set if the depth was "1" or "8".
So the $cmd line was adding an empty pipe step in the case of 24bit.


Solutions:

a) in code that sets up "ppmquant 8" or "ppmquant 256" add a test for 24-bitness
and set to "ppmquant 16777216"

 ... but there should be no need to call  ppmquant  at all
in this case ...


or

b) if 24-bit just skip the ppmquant step. Patch for this solution follows.

--- /usr/bin/pstoimg    2005-03-21 01:27:23.000000000 +1200
+++ pstoimg     2005-07-12 21:22:41.000000000 +1200
@@ -1271,10 +1271,12 @@
   }
   # run ppmquant only on color/gray images
   if(!$type || $type =~ /(ppm|pgm)/i) {
-    if($cmd) {
-      $cmd .= "| $reduce_color "
-    } else {
-      $cmd = "$reduce_color < $in ";
+    if($opt{depth} != 24) {
+      if($cmd) {
+        $cmd .= "| $reduce_color "
+      } else {
+        $cmd = "$reduce_color < $in ";
+      }
     }
   }


This line cannot be coming from  v1.19 of  pstoimg.pin .

There the problem has been fixed by changing the first conditional
to be:

   if( $reduce_color && (!$type || $type =~ /(ppm|pgm)/i)) {


And this bug has been around since the Potato days!

The CVS log for  pstoimg.pin  shows that the bug was fixed some
time ago:

revision 1.17
date: 2003/12/31 15:06:21;  author: RRM;  state: Exp;  lines: +7 -4
--  fixed bug stopping  -depth 24  from working
     thanks to Tino Keitel <[EMAIL PROTECTED]>  for the report.


... which is 10 months earlier than the date on the  2002-2-1 archive,
which indeed contains the correct version of  pstoimg.pin .




cheers,
Hamish


-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.27-2-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages latex2html depends on:
ii  gs                            8.01-5     Transitional package
ii gs-gpl [gs] 8.01-5 The GPL Ghostscript PostScript int
ii  netpbm                        2:10.0-8   Graphics conversion tools
ii perl 5.8.4-8 Larry Wall's Practical Extraction
ii  tetex-bin                     2.0.2-30   The teTeX binary files
ii tetex-extra 2.0.2c-8 Additional library files of teTeX

-- no debconf information




Hope this helps,

    Ross

------------------------------------------------------------------------
Ross Moore                                         [EMAIL PROTECTED]
Mathematics Department                             office: E7A-419
Macquarie University                               tel: +61 +2 9850 8955
Sydney, Australia  2109                            fax: +61 +2 9850 8114
------------------------------------------------------------------------


_______________________________________________
latex2html mailing list
latex2html@tug.org
http://tug.org/mailman/listinfo/latex2html

Reply via email to