-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Barry Warsaw wrote: > = ReviewerMeeting20090909 = > > == summary == > > * don't use `__iter__()` for things that aren't obviously collections > * watch out for leaking the open file descriptor returned from `mkstemp()` > * use `addCleanup()` > * use `mkdtemp()` > * use `os.fdopen()` > * watch out for cleanup of other external resources
Also, remember that TestCaseWithFactory.useTempDir is your friend. Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkqqlh0ACgkQ0F+nu1YWqI067ACeOgNaExBfux6zwAqgKWwN81bc bzIAn0k7PpXGbH+MpIfQdjjEeTdzIEMs =lSNr -----END PGP SIGNATURE----- _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
