On Sat, Oct 24, 2009 at 09:03:14AM -0000, [email protected] wrote: > Merge authors: > Graham Binns (gmb) > Related merge proposals: > > https://code.launchpad.net/~gmb/launchpad/make-me-super-bug-438985/+merge/13840 > proposed by: Graham Binns (gmb) > review: Approve - Abel Deuring (adeuring) > ------------------------------------------------------------ > revno: 9767 [merge] > committer: Launchpad Patch Queue Manager <[email protected]> > branch nick: launchpad > timestamp: Sat 2009-10-24 10:00:34 +0100 > message: > [r=abel][ui=none][bug=438985] Setting yourself as bug supervisor will > no longer OOPS. > modified: > lib/canonical/launchpad/database/structuralsubscription.py > lib/lp/registry/tests/test_product.py > lib/lp/testing/factory.py
> === modified file 'lib/lp/registry/tests/test_product.py' > --- lib/lp/registry/tests/test_product.py 2009-08-13 19:03:36 +0000 > +++ lib/lp/registry/tests/test_product.py 2009-10-23 13:48:28 +0000 > @@ -145,5 +150,31 @@ > 'new') > > > +class BugSupervisorTestCase(TestCaseWithFactory): > + """A TestCase for bug supervisor management.""" > + > + layer = LaunchpadFunctionalLayer > + > + def setUp(self): > + super(BugSupervisorTestCase, self).setUp() > + self.person = self.factory.makePerson() > + self.product = self.factory.makeProduct(owner=self.person) > + login(self.person.preferredemail.email) > + > + def testPersonCanSetSelfAsSupervisor(self): > + # A person can set themselves as bug supervisor for a product. > + # This is a regression test for bug 438985. > + user = getUtility(IPersonSet).getByName(self.person.name) Did you try to change makePerson() not to strip the security proxy as we discussed? Or add an XXX if it broke too many tests? -- Björn Tillenius | https://launchpad.net/~bjornt _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
