On Fri, Nov 6, 2009 at 7:12 AM, Aaron Bentley <[email protected]> wrote: > Julian Edwards wrote: >>> Does job_type indicate whether it is a BuildPackageJob, >>> BuildPackageRecipeJob or BuildTranslationsJob? Or would it be a subtype? >> >> Yes, it would contain an enum which lists all job types possible for the >> build >> farm. > > Gotcha. That's slightly different from the way BranchJobs and > BranchMergeProposalJobs work. For them, the job_type indicates a > subtype, e.g. UpdatePreviewDiff. All BranchMergeProposalJobs use the > same table, whether they are UpdatePreviewDiffJobs or > MergeProposalCreatedJobs. They just store different data in the > json_data column. > > Our original proposal was closer to yours, but we ended up with this > design because of concerns about creating a new table for every new job > type. >
I've just approved a patch from Muharem along the lines of this email discussion. We need to be aware of the possible confusion between 'job_type' in the build queue sense and 'job_type' in the BranchJob sense, and do what we can to avoid it / reduce it. I'd personally like to see us develop a good, consistent set of names for all of these things -- it'll make conversation that much easier. Very excited that this is getting underway. I'm keen to see what we learn after we get the first non-packagebuild job into the system. jml _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
