Hey Guilherme. +1. Thank you I recommend adding the import to lib/lp_sitecustomize.py, FWIW.
Gary On Jun 7, 2010, at 11:23 AM, Guilherme Salgado wrote: > Hi Gary, > > I was hoping to land my branch switching LP to use the default system > python today, but got this failure. It only happens when the default > system python is 2.5 and I think we can easily fix it by making whatever > generates syte.py include an "from __future__ import with_statement" > line. How does that sound to you? > > -------- Forwarded Message -------- > From: Guilherme Salgado <[email protected]> > To: Guilherme Salgado <[email protected]> > Subject: Test results: FAILURE > Date: Mon, 7 Jun 2010 15:46:58 +0100 (BST) > > Tests started at approximately Mon, 07 Jun 2010 12:02:20 UTC > bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/, revision 10952 > > Merged with > bzr+ssh://bazaar.launchpad.net/~salgado/launchpad/use-default-python, > revision 10677 (commit message: Update shipit to r8906) > > Exception UserWarning: > UserWarning("'LockableFiles(<bzrlib.transport.local.LocalTransport > url=file:///tmp/testbzr-8H7JY1.tmp/lp.codehosting.puller.tests.test_worker.TestPullerWorker.test_defaultStackedOnBranchIncompatibleMirrorsOK/work/default-stack-on/.bzr/repository/>)' > was gc'd while locked",) in <bound method _LockWarner.__del__ of > <bzrlib.lockable_files._LockWarner object at 0xecdbf10>> ignored > ====================================================================== > FAILURE: > lp.services.scripts.tests.test_all_scripts.ScriptsTestCase.test_scripts > (subunit.RemotedTestCase) > ---------------------------------------------------------------------- > _StringException: Text attachment: traceback > ------------ > Traceback (most recent call last): > _StringException: Text attachment: traceback > ------------ > Traceback (most recent call last): > File > "/var/launchpad/tmp/eggs/testtools-0.9.2-py2.6.egg/testtools/runtest.py", > line 128, in _run_user > return fn(*args) > File > "/var/launchpad/tmp/eggs/testtools-0.9.2-py2.6.egg/testtools/testcase.py", > line 368, in _run_test_method > testMethod() > File > "/var/launchpad/test/lib/lp/services/scripts/tests/test_all_scripts.py", line > 28, in test_scripts > self.failIf(bad, '\n\n'.join(bad)) > File "/usr/lib/python2.6/unittest.py", line 321, in failIf > if expr: raise self.failureException, msg > AssertionError: /var/launchpad/test/cronscripts/update-database-stats.py > failed > /var/launchpad/test/parts/scripts/site.py:143: Warning: 'with' will become a > reserved keyword in Python 2.6 > Traceback (most recent call last): > File "/var/launchpad/test/cronscripts/update-database-stats.py", line 9, in > <module> > import _pythonpath > File "/var/launchpad/test/cronscripts/_pythonpath.py", line 59, in <module> > import site # sets up paths > File "/var/launchpad/test/parts/scripts/site.py", line 143 > with f: > ^ > SyntaxError: invalid syntax > > > > > -- > Guilherme Salgado <https://launchpad.net/~salgado> > _______________________________________________ > Mailing list: https://launchpad.net/~launchpad-dev > Post to : [email protected] > Unsubscribe : https://launchpad.net/~launchpad-dev > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
