-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/27/2010 09:33 AM, Paul Hummer wrote: > On Tue, 26 Oct 2010 12:55:31 -0400 > Aaron Bentley <[email protected]> wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 10/26/2010 12:19 PM, Paul Hummer wrote: >>> On Tue, 26 Oct 2010 16:52:24 +0100 >>> Gavin Panella <[email protected]> wrote: >>>> >>>> https://code.edge.launchpad.net/~allenap/launchpad/remove-with-statement/+merge/39381 >>> >>> This is a perfect example of a branch that doesn't need a review. >> >> Is it? What if I'd submitted such a branch last week? > > Well, Gavin didn't send it without context.
I don't mean "submit it for review", I mean "skip the review and submit to PQM". > I knew what it was doing, > and why. In that case, I don't need to look at it. It's a rubber > stamp. But if such a branch were submitted last week and I had been > given the same context, my red flag is already being set off before I > look at any code. If I'd thought such a branch didn't need review and skipped review, you wouldn't have seen it until it landed. Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzIMLoACgkQ0F+nu1YWqI3pwwCeMwmvkKCYx+aaKMkGxVa7/9Ny LjMAniXoyQTiQxQ3ZxQEkQvQNVOjHUba =u6Vk -----END PGP SIGNATURE----- _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
