On 15 May 2011 10:00, Robert Collins <[email protected]> wrote:
> On Sun, May 15, 2011 at 3:32 AM, Max Bowsher <[email protected]> wrote:
>> Some team with [email protected] is still a member of ~vcs-imports
>> and is causing bouncebacks to me whenever I modify a code import.
>
> I'll look into this on Monday - we did rollback the removal, but I
> need to check we've addressed all the reasons we rolled it back before
> removing the address again.
I got one of these when I proposed a merge into lazr.restful.
Martin
Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com)
by chlorine.canonical.com with esmtp (Exim 4.71)
(envelope-from <[email protected]>)
id 1QQ5NQ-0001BT-IL
for [email protected]; Fri, 27 May 2011 22:19:28 +0000
Subject: [Merge] lp:~mbp/lazr.restfulclient/789369-getattr
into lp:lazr.restfulclient
From: [email protected]
To: [email protected]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1904881733204449913=="
Message-ID: <[email protected]>
Date: Fri, 27 May 2011 22:19:27 +0000
Precedence: bulk
X-BeenThere: [email protected]
X-Mailman-Version: 2.1.13
List-Id: Launchpad Bug Reports <launchpad-bugs.lists.canonical.com>
X-List-Administrivia: yes
Sender: [email protected]
Errors-To: [email protected]
--===============1904881733204449913==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Your message was rejected
--===============1904881733204449913==
Content-Type: message/rfc822
MIME-Version: 1.0
Received: from adelie.canonical.com ([91.189.90.139])
by chlorine.canonical.com with esmtp (Exim 4.71)
(envelope-from <[email protected]>)
id 1QQ5NO-0001AQ-R4
for [email protected]; Fri, 27 May 2011 22:19:27 +0000
Received: from loganberry.canonical.com ([91.189.90.37])
by adelie.canonical.com with esmtp (Exim 4.71 #1 (Debian))
id 1QQ5NO-0008RA-LC
for <[email protected]>; Fri, 27 May 2011 22:19:26
+0000
Received: from loganberry.canonical.com (localhost [127.0.0.1])
by loganberry.canonical.com (Postfix) with ESMTP id 9CBE02E8019
for <[email protected]>; Fri, 27 May 2011 22:19:26
+0000 (UTC)
Content-Type: multipart/mixed; boundary="===============5954271197669231483=="
MIME-Version: 1.0
X-Launchpad-Message-Rationale: Reviewer @lazr-developers
X-Launchpad-Notification-Type: code-review
X-Launchpad-Branch: ~mbp/lazr.restfulclient/789369-getattr
Reply-To: [email protected]
Message-Id: <[email protected]>
X-Launchpad-Project: lazr.restfulclient
To: [email protected]
From: Martin Pool <[email protected]>
Subject: [Merge] lp:~mbp/lazr.restfulclient/789369-getattr into
lp:lazr.restfulclient
Date: Fri, 27 May 2011 22:19:26 -0000
Sender: [email protected]
Errors-To: [email protected]
Precedence: bulk
X-Generated-By: Launchpad (canonical.com); Revision="13117";
Instance="initZopeless config overlay"
X-Launchpad-Hash: d5db5b309103484064a32fb1459206093f7560c0
--===============5954271197669231483==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Martin Pool has proposed merging lp:~mbp/lazr.restfulclient/789369-getattr =
into lp:lazr.restfulclient.
Requested reviews:
LAZR Developers (lazr-developers)
Related bugs:
Bug #789369 in lazr.restfulclient: "useless "'Entry' object has no attrib=
ute" error message"
https://bugs.launchpad.net/lazr.restfulclient/+bug/789369
For more details, see:
https://code.launchpad.net/~mbp/lazr.restfulclient/789369-getattr/+merge/62=
743
This makes lazr.restful give you an error like so:
AttributeError: 'https://api.launchpad.net/1.0/~chrisjohnston/launchpad/483=
373' object has no attribute 'queue_status'
which personally I think is much more useful.
-- =
https://code.launchpad.net/~mbp/lazr.restfulclient/789369-getattr/+merge/62=
743
Your team LAZR Developers is requested to review the proposed merge of lp:~=
mbp/lazr.restfulclient/789369-getattr into lp:lazr.restfulclient.
--===============5954271197669231483==
Content-type: text/x-diff
Content-Disposition: inline; filename="review-diff.txt"
Content-Transfer-Encoding: quoted-printable
=3D=3D=3D modified file 'src/lazr/restfulclient/resource.py'=0A--- src/lazr=
/restfulclient/resource.py 2011-02-03 16:39:52 +0000=0A+++
src/lazr/restful=
client/resource.py 2011-05-27 22:19:23 +0000=0A@@ -330,8 +330,8 @@=0A
=
try:=0A return self.lp_get_parameter(attr)=0A except=
KeyError:=0A- raise AttributeError("'%s' object has no attribut=
e '%s'"=0A- % (self.__class__.__name__, att=
r))=0A+ raise AttributeError("%s object has no attribute '%s'"=
=0A+ % (self, attr))=0A =0A def lp_values_for(self, para=
m_name):=0A """Find the set of possible values for a parameter."""=
=0A=0A
--===============5954271197669231483==--
--===============1904881733204449913==--
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-dev
More help : https://help.launchpad.net/ListHelp
