Review: Needs Information code
I think the failure handler on line 318 should use the red flash anim. Maybe
this action never flashed red on failure. Oh I see the widget never flashed
read on failure, but you can fix a stupid case where red was flashed on success.
_unlink_bug_success on line 557 must flash green to state that the action was
successful. I think this is another case where developer thought red me remove,
when it actually means failure.
I wonder if all the calls to
that.set('error', response.responseText)
should instead call a method that does this an flash red. I will let you choose
to decide if this should be done.
The message on line 610 is ambiguous. Does it mean only some people will see
the branch fixes the bug, or does it mean that the branch will be made private
too?
--
https://code.launchpad.net/~wallyworld/launchpad/link-branch-to-bug-411409/+merge/118083
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
