This branch looks fine. I have one concern though. In lib/lp/registry/javascript/tests/test_product_views.html, the very large HTML template makes me worry about maintainability. Will that have to be carefully hand maintained? Was that generated by something? If so, can we generate it at runtime instead?
-- https://code.launchpad.net/~rharding/launchpad/regjs/+merge/125780 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/regjs into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
