Hi Raphaël,
thanks for the review.
- added a check for the user-data passed on to nodes verifying the apt-proxy
variable is properly set.
- added a skipIf, so this test will be skipped if the tests run on anything
other than raring.
- clarified the two different proxy URLs we have. One is for squid-deb-proxy
and another for the squid proxy.
I didn't use absolute_reverse to build the user-data URL because that was
returning the wrong URL base for the view (i.e. without /MAAS/)
>>> absolute_reverse('enlist')
'http://192.168.21.5/metadata/enlist'
The reason the test was failing to found the proxy URL in the user-data is
because I was running them on quantal, and as you said to me, on quantal
setting the proxy URL doesn't have any effect. Is this feature going to be
ported to quantal?
I think with this last set of changes this is good to merge. What do you think?
Cheers,
Diogo
--
https://code.launchpad.net/~matsubara/maas/set-proxy/+merge/151074
Your team MAAS Maintainers is requested to review the proposed merge of
lp:~matsubara/maas/set-proxy into lp:~maas-maintainers/maas/qa-lab-tests.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
