Review: Approve
Diff comments: > > === modified file 'lib/lp/security.py' > --- lib/lp/security.py 2016-08-23 08:05:44 +0000 > +++ lib/lp/security.py 2016-09-20 00:39:35 +0000 > @@ -1710,9 +1710,8 @@ > usedfor = IProductRelease > > def checkAuthenticated(self, user): > - if (user.inTeam(self.obj.productseries.owner) or > - user.inTeam(self.obj.productseries.product.owner) or > - user.inTeam(self.obj.productseries.driver)): > + if (user.isOwner(self.obj.productseries.product) or Hm. How odd. Seems OK then, but perhaps you should update the (API-doc-visible) description of IProductSeries.driver to match. > + user.isDriver(self.obj.productseries)): > # The user is an owner or a release manager. > return True > return EditByOwnersOrAdmins.checkAuthenticated( -- https://code.launchpad.net/~wgrant/launchpad/bug-1083709-again/+merge/306167 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
