Review: Approve code
Diff comments: > > === modified file 'lib/lp/registry/model/distroseries.py' > --- lib/lp/registry/model/distroseries.py 2019-02-13 14:39:18 +0000 > +++ lib/lp/registry/model/distroseries.py 2019-04-16 11:18:04 +0000 > @@ -1110,7 +1110,9 @@ > SourcePackagePublishingHistory.pocket == pocket, > SourcePackagePublishingHistory.component == component, > SourcePackagePublishingHistory.status == > - PackagePublishingStatus.PUBLISHED) > + PackagePublishingStatus.PUBLISHED, > + SourcePackagePublishingHistory.sourcepackagename == > + SourcePackageName.id).order_by(SourcePackageName.name) This and the BPPH equivalent are likely to change the execution plan significantly, but I guess since we seem to only ever pull the whole set it won't be fatal. > > def eager_load(spphs): > # Preload everything which will be used by archivepublisher's -- https://code.launchpad.net/~cjwatson/launchpad/fix-ordering/+merge/366102 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
