Diff comments:
> diff --git a/charm/launchpad-ftpmaster-publisher/config.yaml
> b/charm/launchpad-ftpmaster-publisher/config.yaml
> index d871574..b33716b 100644
> --- a/charm/launchpad-ftpmaster-publisher/config.yaml
> +++ b/charm/launchpad-ftpmaster-publisher/config.yaml
> @@ -7,6 +7,18 @@ options:
> type: string
> description: Domain name for the published Ubuntu archive.
> default: "archive.ubuntu.test"
> + ftp_auth_users:
Here I differentiated auth_users for the [ftp] entry and [partner]. I don't
know if it makes sense but they may have different configurations. Same for
hosts_allow.
> + type: string
> + description: Authenticated users for rsync ubuntu
> + default: ""
> + ftp_secrets:
> + type: string
> + description: Path for rsync secrets
> + default: ""
> + partner_auth_users:
> + type: string
> + description: Authenticated users for rsync ubuntu-partner
> + default: ""
> signing_client_public_key:
> type: string
> description: Public key for encrypting communication between client and
> signing service.
--
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/453838
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launchpad:ftpmaster-publisher-configuration into launchpad:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
