Diff comments:
> diff --git a/lpbuildd/target/build_rock.py b/lpbuildd/target/build_rock.py
> index 2da488c..6eeb312 100644
> --- a/lpbuildd/target/build_rock.py
> +++ b/lpbuildd/target/build_rock.py
> @@ -76,7 +87,14 @@ class BuildRock(
> "python3-setuptools",
> ]
> )
> - self.backend.run(["apt-get", "-y", "install"] + deps)
> + if env:
I do not like inline conditions, as things get harder to read, and harder to
debug with a debugger.
> + self.backend.run(["apt-get", "-y", "install"] + deps, env=env)
> + else:
> + self.backend.run(["apt-get", "-y", "install"] + deps)
> + if self.args.use_fetch_service:
> + self.install_snapd_proxy(proxy_url=self.args.proxy_url)
> + self.restart_snapd()
> + self.configure_git_protocol_v2()
> if self.backend.supports_snapd:
> self.snap_store_set_proxy()
> for snap_name, channel in sorted(self.args.channels.items()):
--
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/473926
Your team Launchpad code reviewers is requested to review the proposed merge of
~pelpsi/launchpad-buildd:fetch-service-apt-initialization into
launchpad-buildd:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
