LGTM, but need to fix the value in LaunchpadDatabaseRevision Diff comments:
> diff --git a/database/schema/patch-2211-29-1.sql > b/database/schema/patch-2211-29-1.sql > new file mode 100644 > index 0000000..ee6421a > --- /dev/null > +++ b/database/schema/patch-2211-29-1.sql > @@ -0,0 +1,10 @@ > +-- Copyright 2024 Canonical Ltd. This software is licensed under the > +-- GNU Affero General Public License version 3 (see the file LICENSE). > + > +SET client_min_messages=ERROR; > + > +ALTER TABLE CraftRecipe ADD COLUMN use_fetch_service boolean DEFAULT false > NOT NULL; > + > +COMMENT ON COLUMN CraftRecipe.use_fetch_service IS 'Whether to use the > fetch-service in place of the builder-proxy when building this craft.'; > + > +INSERT INTO LaunchpadDatabaseRevision VALUES (2211, 28, 2); There seems to be a mismatch between this and the name of the file, I'm guessing this should be (2211, 29, 1) > \ No newline at end of file -- https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/474002 Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:add-fetch-service-column-to-craftrecipe into launchpad:db-devel. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
