Diff comments:
> diff --git a/lib/lp/crafts/model/craftrecipebuildjob.py
> b/lib/lp/crafts/model/craftrecipebuildjob.py
> index 0afc460..f3d939e 100644
> --- a/lib/lp/crafts/model/craftrecipebuildjob.py
> +++ b/lib/lp/crafts/model/craftrecipebuildjob.py
> @@ -462,6 +462,12 @@ class CraftPublishingJob(CraftRecipeBuildJobDerived):
> f.write(settings_xml)
>
> # Run mvn deploy using the pom file
> + env = os.environ.copy()
> + env["MAVEN_OPTS"] = (
> + "-Xmx128m -Xms128m "
This seems unnecessarily small. I would probably aim much higher; maybe 8192
MB. Test it, though; ymmv.
> + "-XX:CompressedClassSpaceSize=32m "
Similarly here; you can avoid to have much larger numbers IMHO.
> + "-XX:MaxMetaspaceSize=64m"
> + )
> result = subprocess.run(
> [
> "mvn",
--
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/490254
Your team Launchpad code reviewers is requested to review the proposed merge of
~ruinedyourlife/launchpad:maven-explanation-and-logs into launchpad:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
