--- Graeme Geldenhuys <[EMAIL PROTECTED]> escribió: > Hi > > Attached is a patch for the TCustomGrid.GridLineWidth property. > Please > review before applying this patch. >
Looks ok, the only problem I see is that, currently the property default for GridLineWidth is set to 1, but as grid doesn't set the GridLineWidth at creation it takes value 0, this value is stored in lfm file for every project that uses grids (TDrawGrid and TStringGrid) previous to this patch, nobody reported this bug before I think because it didn't have any effect. But now people will find suddenly their grids doesn't have gridlines, the fix is just to change the value to 1 in object inspector and save the form. This have to be done anyway, so I applied the patch in revision 10961 and fixed the grid lines in lazarus sources in revision 10962 > This is not a full implementation but rather a quick cosmetic > implementation. The difference is that this patch changes the grid > line width for painting only, but not the actual offset or regions > of > the cells due to the change in Grid Line Width. No problem, it's the way it works currently. > Fixed columns > don't > draw the grid lines thicker than 1 (not sure if this is correct > behaviour). I don't think it is, I will try to fix it. > > At least with this patch you are now able to hide the grid lines > (GridLineWidth = 0) when required. This is the main feature I was > missing to get my custom component to work. I agree it does a better work than the current methods. > > In the Delphi implementation, the cell size will stay the same even > though the grid line width increases. Delphi does cause a very > strange effect (I think it's a bug) when the GridLineWidth is set > to a > negative values. I don't think Lazarus needs to copy that > behaviour > so the lowest value the GridLineWidth will go is 0 in the LCL. > I agree, we will have to change this so it becomes more delphi compatible anyway, but for the moment I think it's ok as is. > > > -- > Graeme Geldenhuys Thanks. Jesus Reyes A. __________________________________________________ Correo Yahoo! Espacio para todos tus mensajes, antivirus y antispam ¡gratis! Regístrate ya - http://correo.yahoo.com.mx/ _________________________________________________________________ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
