On 13 February 2014 12:35, <marti.ma...@littlecms.com> wrote: > 1) Any client using THR functions and the lib as shared object > is basically broken. if a client sets a listener or plug-in, > it got events from any other clients of the .so, with > obviously unexpected user data format. This causes segfaults.
Right, and in the case of the ghostscript guys that makes complete sense. If you're a single threaded application or command line program using lcms that argument breaks down somewhat. > 3) Some cases (small integers, pointers to structures) are > detected automatically. Those cases were NOT WORKING > previously because rule 1) and now are fixed. They might be detected automatically in most cases, but if you try to run valgrind on any program using the new version of lcms you get: ==2376== More than 10000000 total errors detected. I'm not reporting any more. ==2376== Final error counts will be inaccurate. Go fix your program! > So basically this is breaking the ABI compatibility, but the > cases where ABI is broken were not working anyway. So hence > the decision of fixing the whole thing at the expense of ABI > compatibility. Okay, I agree. But you can't pretend you're not breaking ABI by fixing bugs in the API. The argument "this was broken for some users" doesn't mean you can break it for most users. > I agree a .soname bump should be required here. I can even > do a major version bump to lcms2-3.0, your feedback would > be appreciated. Well, you *have* to bump LT_REVISION and I would argue that LT_CURRENT is required as well. Of course, if you bump LT_CURRENT then world and dog will want liblcms2.so.3 parallel installable with liblcms2.so.2. It's not that hard to package the two versions in parallel. Whether it should be called lcms3 is another issue altogether. Richard. ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Lcms-user mailing list Lcms-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lcms-user
