Hi David on 16.05.2011 21:33, davidMbrooke wrote: > On Mon, 2011-05-16 at 10:40 +0200, Erich Titl wrote: >> Hi Folks >> >> It appears that the environment variables from buildtool.cfg are not >> passed to the makefile for the buildclean and srcclean operations. Could >> someone with insight in these modules please comment? >> >> Thanks >> >> Erich > > > Hi Erich, > > I have noticed the same behaviour. Some of the makefiles automatically > derive the directory name from the source .tar.gz contents but that does > not work for buildclean / srcclean so they have to save off the > directory name to a file (called "DIRNAME") in order to use the name > later, when the environment variables are not set. > > Would a similar approach work for you? Look at the first few lines of > e.g. repo/nfs-utils/buildtool.mk as an example.
It might work, but like every file based state flag it is extremely error prone. If we stick with the buildtool code I would suggest to port the _makeEnvString ($$) method from buildtool::Make::Source to buildtool::Make::Common. I have not completely checked this though. Maybe Martin would know. It's been some time since I programmed objects in perl and I woudl lie if said I like the syntax, but this could be one way to get to cleaner makefiles. I don't like to have to touch buildtool.mk just because the version number of a package changes. All this should be in the config file. cheers Erich ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ leaf-devel mailing list leaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/leaf-devel
