On 06/20/2016 09:59 AM, Matthias Schiffer wrote: > When a process quits in response to a signal it handles, it should to so > be re-sending the signal to itself. This especially important for SIGINT, > as is explained in [1]. > > uloop currently hides the reason for quitting uloop_run(). Fix this by > returning the signal that caused the loop to quit (or 0 when uloop_end() > was used), so a program using loop an comply with [1]. > > uloop_cancelled is renamed to uloop_status, so accidentially running a > process compiled with one uloop_cancelled definition against the other is > not possible.
I've just noticed that this will also require a ubus change, as libubus is accessing uloop_cancelled directly. Would you prefer to keep uloop_cancelled with its old definition and add ubus_status as an additional variable to keep this compatible? An alternative would be to provide a helper uloop_is_cancelled() based on ubus_status and adjust libubus accordingly. Regards, Matthias > > [1] https://www.cons.org/cracauer/sigint.html > > Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net>
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
