* ad...@yapic.net <ad...@yapic.net> [04.07.2016 17:27]:
> +wget_if_URL(){
> +     local url="$1"
> +     local url_repl_file="/tmp/sysupgrade-URL.bin"

empty line here

> +     case "$url" in
> +             http://*|https://*|ftp://*) break ;;
> +             *) return 1 ;;
> +     esac

empty line here

> +     rm -f $url_repl_file

why? if we dont --continue it is overwritten anyway

empty line here


> +     wget "$url" -O "$url_repl_file" || {
> +             echo "Wget return error $? for url '$url'"
> +             echo "Exiting"
> +             rm -f $url_repl_file

empty line here

> +             exit 1

please 'return 1'

> +     }

empty line here


thanks & bye - bastian

_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Reply via email to