On 10/03/16 14:18, Piotr Dymacz wrote: > Hello, > > 2016-10-03 13:14 GMT+02:00 Karl Palsson <ka...@tweak.net.au>: >> >> Jan-Tarek Butt <ta...@ring0.de> wrote: > [snip] >>> 1. Reducing memory size on firmware images. >> >> But will it? They're in the squashfs image, it's already been >> demonstrated before that compressing things before can actually >> have negative impacts. > > That's true, my vote for 'optimization-only' approach and keep fs do > the rest (compression). > >>> 2. Strip out all comments (which makes us able to do better >>> code commenting) 3. and so on. > > IMHO, we could remove all comments from all scripts (not only Lua) in > target rootfs and work on better documentation outside the code. > > As an example of a huge, old comment, left in one of ar71xx base-files > scripts, please see [1]. > It's inside every ar71xx image... does it really make sense to have it > there, for devices without related hardware?
Exactly that's my point. I mean that is really not necessary. And the comments will be stay inside the git. Only on the final images there will be gone. cheers Tarek
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
