John, Sounds good. My only question is around the current RFC for the PC Engines APU2 which has this application defined in the profile for the board. Would that be enough justification to allow this into the LEDE branch, or would it be OK to keep "beep" defined in the profile and just merge this into the packages feed?
Regards, Chris Blake On Thu, Oct 27, 2016 at 5:08 AM, John Crispin <j...@phrozen.org> wrote: > Hi, > > after some time considering i am against merging this into trunk. there > are no direct users and no hardware that wont function without. please > submit the package as a PR to the packages feed. > > John > > On 19/10/2016 16:59, Chris Blake wrote: >> This adds the "beep" binary as a package to LEDE. Note that busybox does >> have a beep option that can be built in, but it is disabled by default >> on all LEDE targets. This package gives users the option to manually >> install beep at a later time, or include it as a default for a device >> profile. >> >> This was based on the older PR at https://lists.openwrt.org/pipermail >> /openwrt-devel/2009-November/005226.html >> >> Signed-off-by: Chris Blake <chrisrblak...@gmail.com> >> --- >> package/utils/beep/Makefile | 50 >> +++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> create mode 100644 package/utils/beep/Makefile >> >> diff --git a/package/utils/beep/Makefile b/package/utils/beep/Makefile >> new file mode 100644 >> index 0000000..b9bb4d80 >> --- /dev/null >> +++ b/package/utils/beep/Makefile >> @@ -0,0 +1,50 @@ >> +# >> +# Copyright (C) 2016 OpenWrt.org >> +# >> +# This is free software, licensed under the GNU General Public License v2. >> +# See /LICENSE for more information. >> +# >> + >> +include $(TOPDIR)/rules.mk >> + >> +PKG_NAME:=beep >> +PKG_REV:=0d790fa45777896749a885c3b93b2c1476d59f20 >> +PKG_VERSION:=1.3 >> +PKG_RELEASE:=1 >> + >> +PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz >> +PKG_SOURCE_URL:=https://github.com/johnath/beep.git >> +PKG_SOURCE_PROTO:=git >> +PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) >> +PKG_SOURCE_VERSION:=$(PKG_REV) >> + >> +PKG_LICENSE:=GPL >> +PKG_LICENSE_FILES:= >> + >> +include $(INCLUDE_DIR)/package.mk >> + >> +define Package/beep >> + SECTION:=sound >> + CATEGORY:=Sound >> + DEPENDS:=+kmod-pcspkr >> + TITLE:=Play beep sounds through a PC speaker >> + URL:=http://johnath.com/beep/README >> +endef >> + >> +define Package/beep/description >> + This program plays beeps through the PC speaker >> +endef >> + >> +CONFIGURE_ARGS += \ >> + --enable-static \ >> + --enable-shared >> + >> +MAKE_FLAGS += \ >> + CFLAGS="$(TARGET_CFLAGS)" >> + >> +define Package/beep/install >> + $(INSTALL_DIR) $(1)/usr/bin >> + $(INSTALL_BIN) $(PKG_BUILD_DIR)/beep $(1)/usr/bin >> +endef >> + >> +$(eval $(call BuildPackage,beep)) >> -- >> 2.7.4 >> >> _______________________________________________ >> Lede-dev mailing list >> Lede-dev@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/lede-dev >> _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
