On 2017-02-13 09:01, Chris Blake wrote:
> This adds the default LED and network settings for the PC Engines APU2
> when running under the x86 target.
> 
> Signed-off-by: Chris Blake <chrisrblak...@gmail.com>
> ---
>  target/linux/x86/base-files/etc/board.d/01_leds    |  7 +++-
>  target/linux/x86/base-files/etc/board.d/02_network |  7 +++-
>  target/linux/x86/base-files/etc/diag.sh            | 37 
> ++++++++++++++++++++++
>  target/linux/x86/base-files/lib/x86.sh             | 13 ++++++++
>  4 files changed, 62 insertions(+), 2 deletions(-)
>  create mode 100755 target/linux/x86/base-files/etc/diag.sh
>  create mode 100755 target/linux/x86/base-files/lib/x86.sh
> 
> diff --git a/target/linux/x86/base-files/lib/x86.sh 
> b/target/linux/x86/base-files/lib/x86.sh
> new file mode 100755
> index 0000000..40e4d1f
> --- /dev/null
> +++ b/target/linux/x86/base-files/lib/x86.sh
Please leave out the /lib/<platform>.sh anti-pattern. Just use
/tmp/sysinfo/board_name directly or (even better) introduce a generic
function for getting the board name.

- Felix

_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Reply via email to