On Wed, 2017-02-15 at 09:29 +0100, John Crispin wrote: > > > --- a/target/linux/ar71xx/base-files/etc/diag.sh > > +++ b/target/linux/ar71xx/base-files/etc/diag.sh > > @@ -63,6 +63,10 @@ get_status_led() { > > gl-inet) > > status_led="$board:green:lan" > > ;; > > + gl-ar300m|\ > > + gl-mifi) > > + status_led="$board:lan" > > Hi Wojciech, > > patch is technically correct, however while reviewing it i noticed that > the boards do not follow the correct naming scheme. normally it should > be board:color:function. looks like the gl boards are missing the color. > would you mind re-spinning you patch and also fixing the colors inside > target/linux/ar71xx/files/arch/mips/ath79/mach-gl-ar300m.c and > target/linux/ar71xx/files/arch/mips/ath79/mach-gl-mifi.c
Also... ick, we've got board details hard-coded in /etc/diag.sh, which is what I just fixed for x86. Should we promote target/x86/base-files/etc/diag.sh to run *everywhere* and make things work that way?
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev