Hello, On 29/03/2017 10:44:36 CEST, John Crispin wrote: > On 26/03/17 10:08, Vittorio Gambaletta (VittGam) wrote: >> - .phy_fixup = ar8327_phy_fixup, >> + //.phy_fixup = ar8337_phy_fixup, // not needed at the moment >> .set_mirror_regs = ar8327_set_mirror_regs, >> .get_arl_entry = ar8327_get_arl_entry, >> .sw_hw_apply = ar8327_sw_hw_apply > Hi, > > why is this not needed ?
Because QCA in their QSDK only execute the AR8327 fixup function for the AR8327 [0]. Since the fixup function does black magic with hidden or reserved register bits (some are not even appearing in the datasheet...), I think that it's better to leave it out like they do... Cheers, Vittorio [0] https://source.codeaurora.org/quic/qsdk/oss/system/openwrt/tree/target/linux/generic/files/drivers/net/phy/ar8216.c?h=aa%2Fbanana#n1324 _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
