> On 17 Dec 2017, at 21:21, Hauke Mehrtens <ha...@hauke-m.de> wrote:
>
> This patch made GCC produce broken code, remove it.
> In mp_cmp_d() function in th libtommath shipped with dropbear the
> following code was compiled wrong:
>
> /* compare based on magnitude */
> if (a->used > 1) {
> return 1;
> }
>
> In the broken ASM this part returned -1 like the previous return
> statement did instead of 1 like it should.
>
> This did not happen when the -funroll-loops option was given to GCC.
>
> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de>
> ---
> .../7.2.0/300-mips_Os_cpu_rtx_cost_model.patch | 21 ---------------------
> 1 file changed, 21 deletions(-)
> delete mode 100644
> toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
>
> diff --git a/toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
> b/toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
> deleted file mode 100644
> index 84c0fdab66..0000000000
> --- a/toolchain/gcc/patches/7.2.0/300-mips_Os_cpu_rtx_cost_model.patch
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -commit ecf7671b769fe96f7b5134be442089f8bdba55d2
> -Author: Felix Fietkau <n...@nbd.name>
> -Date: Thu Aug 4 20:29:45 2016 +0200
> -
> -gcc: add a patch to generate better code with Os on mips
> -
> -Also happens to reduce compressed code size a bit
> -
> -Signed-off-by: Felix Fietkau <n...@nbd.name>
> -
> ---- a/gcc/config/mips/mips.c
> -+++ b/gcc/config/mips/mips.c
> -@@ -19784,7 +19784,7 @@ mips_option_override (void)
> - flag_pcc_struct_return = 0;
> -
> - /* Decide which rtx_costs structure to use. */
> -- if (optimize_size)
> -+ if (0 && optimize_size)
> - mips_cost = &mips_rtx_cost_optimize_size;
> - else
> - mips_cost = &mips_rtx_cost_data[mips_tune];
> --
> 2.11.0
> I have long carried an identical patch in my tree - see FS#814 Tested-by: <l...@darbyshire-bryant.me.uk> Cheers, Kevin D-B GPG fingerprint: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
