Thanks John, I can't reproduce the save error you are seeing. I will keep trying.
As far as the transaction reconciliation behavior you are seeing, that is as intended. I will see if I can make it configurable to clear only the posting from the reconcile window. C-c C-c inthe ledger buffer still clears only the posting you are on... In my mind I clear the entire transaction (especially if their are only two postings, in your example why wouldn't also clear the expenses posting?). On Sat, Feb 9, 2013 at 7:47 AM, John Rakestraw <[email protected]> wrote: > Hi, Craig -- > > Thanks for your continued work on this. I'm really sorry I don't have time > right now to bang on this really hard, but here's what I uncovered with a > few minutes work. > > >> 1. Fixed, spacebar toggling now also scrolls the buffer > > > Yes, I can confirm that this is fixed. > >> >> 2. That was my personal preference. I made it configurable using >> ledger-reconcile-force-window-bottom in the ledger group > > > I appreciate your adding this option. This also now works as expected. > >> >> 3. That looks like a ledger problem. I think I have run across the >> same thing, or it has been commented on here recently. > > > Yes, I should have realized that. (I think it's a recently introduced bug, > though.) > >> >> 4. Thanks I didn't remove a hook form the ledger buffer after the >> recon window is killed. Sloppy >> 5. C-c C-c has now been replaced with "s" to save. Let me know if it >> doesn't work as you expect. The command bound to C-c C-c has been >> broken for a while and I combined it with save. > > > When I'm in the reconcile window and hit "s" to save, I get the error "end > of file during parsing" and the file doesn't save. If I quit reconcile with > "q", the reconcile window closes adn I'm asked "buffer modified, kill > anyway?" If I hit "n", then I'm left with the ledger file open but unsaved > and I can save it. If I hit "y", I lose my changes. > > One other point -- I noticed in my tests that marking a posting as cleared > in the reconcile window marks the entire transaction as cleared rather than > just that posting. If I'm reconciling my checking account, I would expect > the transaction to be marked this way: > > 2013/02/01 Check for groceries > Expenses:Groceries $10.00 > * Account:Checking > > But instead it's marked this way: > > 2013/02/01 * Check for groceries > Expenses:Groceries $10.00 > Account:Checking > > Again, it's possible that it's user error. I pulled from git and then > transferred the ledger lisp files to my the directory with my other lisp > files. Let me know if I should be doing something else. > > Thanks. > > --John > > >> >> Thanks for the help! >> On Fri, Feb 8, 2013 at 7:32 PM, John Rakestraw <[email protected]> >> wrote: >> > Hi, Craig -- >> > >> > >> > On Friday, February 8, 2013 7:17:37 PM UTC-5, Craig Earls wrote: >> >> >> >> John, >> >> I have that feature in now and pushed to the server. Let me know if >> >> it is what you wanted. >> > >> > >> > This is promising -- thanks for working on it. But I think there are >> > some >> > rough spots. I'm swamped with work and home life right now, so I can't >> > do a >> > lot of tests, but here are a few things I see -- >> > >> > - The follow works fine when I use the cursor key to move from one entry >> > to >> > the next. However, when I use the space bar to go through the list of >> > entries in the reconcile window, the other window doesn't follow. >> > - The reconcile window now opens below the ledger window -- I'd rather >> > have >> > it follow my regular setting, which would have it open to the right of >> > my >> > ledger window >> > - It seems that the ledger file no longer allows the me to post the >> > actual >> > total value of the account, as in this: >> > >> > 2013/02/08 Make the account value right >> > This:Account = $50.00 >> > Another:2dAccount >> > >> > When I run a report with an entry like this, I get "Error: Only one >> > posting >> > with null amount allowed per transaction" with a line number referencing >> > that transaction. >> > >> > - When I'm in ledger mode and save the ledger, the file saves properly, >> > but >> > I get this backtrace with debug-on-error set: >> > >> > set-buffer(#<killed buffer>) >> > (save-current-buffer (set-buffer buf) (let ((coding-system-for-write >> > (quote utf-8)) (coding-system-for-read (quote utf-8))) (apply (function >> > call-process-region) (append (list (point-min) (point-max) >> > ledger-binary-path nil outbuf nil "-f" "-") args))) outbuf) >> > (let ((buf (or input-buffer (current-buffer))) (outbuf (or >> > output-buffer >> > (generate-new-buffer " *ledger-tmp*")))) (save-current-buffer >> > (set-buffer >> > buf) (let ((coding-system-for-write (quote utf-8)) >> > (coding-system-for-read >> > (quote utf-8))) (apply (function call-process-region) (append (list >> > (point-min) (point-max) ledger-binary-path nil outbuf nil "-f" "-") >> > args))) >> > outbuf)) >> > ledger-exec-ledger(#<killed buffer> #<buffer *temp*> "--uncleared" >> > "--real" "emacs" "platinum") >> > (progn (ledger-exec-ledger buf (current-buffer) "--uncleared" "--real" >> > "emacs" account) (goto-char (point-min)) (if (eobp) nil (if (looking-at >> > "(") >> > nil (error (buffer-string))) (read (current-buffer)))) >> > (unwind-protect (progn (ledger-exec-ledger buf (current-buffer) >> > "--uncleared" "--real" "emacs" account) (goto-char (point-min)) (if >> > (eobp) >> > nil (if (looking-at "(") nil (error (buffer-string))) (read >> > (current-buffer)))) (and (buffer-name temp-buffer) (kill-buffer >> > temp-buffer))) >> > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn >> > (ledger-exec-ledger buf (current-buffer) "--uncleared" "--real" "emacs" >> > account) (goto-char (point-min)) (if (eobp) nil (if (looking-at "(") nil >> > (error (buffer-string))) (read (current-buffer)))) (and (buffer-name >> > temp-buffer) (kill-buffer temp-buffer)))) >> > (let ((temp-buffer (generate-new-buffer " *temp*"))) >> > (save-current-buffer >> > (set-buffer temp-buffer) (unwind-protect (progn (ledger-exec-ledger buf >> > (current-buffer) "--uncleared" "--real" "emacs" account) (goto-char >> > (point-min)) (if (eobp) nil (if (looking-at "(") nil (error >> > (buffer-string))) (read (current-buffer)))) (and (buffer-name >> > temp-buffer) >> > (kill-buffer temp-buffer))))) >> > (let* ((buf ledger-buf) (account ledger-acct) (items (let >> > ((temp-buffer >> > (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer >> > temp-buffer) (unwind-protect (progn (ledger-exec-ledger buf ... >> > "--uncleared" "--real" "emacs" account) (goto-char ...) (if ... nil ... >> > ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))) (if >> > (> >> > (length items) 0) (progn (let ((--dolist-tail-- items) item) (while >> > --dolist-tail-- (setq item (car --dolist-tail--)) (let ((index 1)) >> > (progn >> > (let ... ...))) (setq --dolist-tail-- (cdr --dolist-tail--))))) (insert >> > (concat "There are no uncleared entries for " account))) (goto-char >> > (point-min)) (set-buffer-modified-p nil) (toggle-read-only t) (let >> > ((recon-window (get-buffer-window (get-buffer >> > ledger-recon-buffer-name)))) >> > (fit-window-to-buffer recon-window) (save-current-buffer (set-buffer >> > buf) >> > (select-window (get-buffer-window buf)) (goto-char (point-max)) >> > (recenter >> > -1)) (select-window recon-window))) >> > ledger-do-reconcile() >> > (let ((inhibit-read-only t) (line (count-lines (point-min) (point)))) >> > (erase-buffer) (ledger-do-reconcile) (set-buffer-modified-p t) >> > (goto-char >> > (point-min)) (forward-line line)) >> > ledger-reconcile-refresh() >> > (save-current-buffer (set-buffer buf) (ledger-reconcile-refresh) >> > (set-buffer-modified-p nil)) >> > (if buf (save-current-buffer (set-buffer buf) >> > (ledger-reconcile-refresh) >> > (set-buffer-modified-p nil))) >> > (let ((buf (get-buffer ledger-recon-buffer-name))) (if buf >> > (save-current-buffer (set-buffer buf) (ledger-reconcile-refresh) >> > (set-buffer-modified-p nil)))) >> > ledger-reconcile-refresh-after-save() >> > run-hooks(after-save-hook) >> > basic-save-buffer() >> > save-buffer(1) >> > call-interactively(save-buffer nil nil) >> > >> > and I have "selecting deleted buffer" in the minibuffer. >> > >> > - Formerly, when I finished reconciling an account, I used C-c C-c to >> > save >> > the reconciliations. Now C-c C-c does nothing, and I don't see how I can >> > save it from the reconciliation window. >> > >> > I did all this pretty quickly, and I suspect that some of these might be >> > the >> > result of user error. But I think that for now I'll revert to the >> > earlier >> > version. >> > >> > Thanks -- >> > >> > John >> > >> > -- >> > >> > --- >> > You received this message because you are subscribed to the Google >> > Groups >> > "Ledger" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an >> > email to [email protected]. >> > For more options, visit https://groups.google.com/groups/opt_out. >> > >> > >> >> >> >> -- >> Craig, Corona De Tucson, AZ >> enderw88.wordpress.com > > -- > > --- > You received this message because you are subscribed to the Google Groups > "Ledger" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > -- Craig, Corona De Tucson, AZ enderw88.wordpress.com -- --- You received this message because you are subscribed to the Google Groups "Ledger" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
